Attention is currently required from: Elyes Haouas, Nico Huber, Paul Menzel.
3 comments:
File src/device/azalia_device.c:
Patch Set #6, Line 259: load_verb
Maybe rather `load_verb_table`. I got a bit confused because we have […]
I can see how the separation is a bit overdone with `get_verb()` and `load_verb()`. I will put those 2 back into `azalia_codec_init()`. 👍
It's more of a `count'. But maybe that's something to take care of later.
Maybe it's just me but I have a feeling that the naming is a bit confusing here in general (e.g. `u32 *verb` feels like it should be plural).
File src/include/device/azalia_device.h:
It's common to indent the bit definitions.
Done
To view, visit change 80332. To unsubscribe, or for help writing mail filters, visit settings.