Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44045 )
Change subject: util/amdfwtool: If no APOB_NV is specified, don't error out ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44045/1/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/44045/1/util/amdfwtool/amdfwtool.c@... PS1, Line 922: if (fw_table[i].type == AMD_BIOS_APOB_NV && fw_table[i].src) { : if (!fw_table[i].size) { We check for src without size here.
https://review.coreboot.org/c/coreboot/+/44045/1/util/amdfwtool/amdfwtool.c@... PS1, Line 930: !fw_table[i].size) { If we enter this loop, we already know that there's no size specified.
https://review.coreboot.org/c/coreboot/+/44045/1/util/amdfwtool/amdfwtool.c@... PS1, Line 933: if (!fw_table[i].src) { so here we only need to check to see if there's also no source specified.