Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43904 )
Change subject: cpu/intel/common: Fill cpu voltage in SMBIOS tables ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43904/5/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/43904/5/src/arch/x86/smbios.c@505 PS5, Line 505: }
This seems unrelated. Also, the function already exists, AFAICS.
Removed.
https://review.coreboot.org/c/coreboot/+/43904/5/src/cpu/intel/common/Makefi... File src/cpu/intel/common/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43904/5/src/cpu/intel/common/Makefi... PS5, Line 3: ramstage-$(CONFIG_CPU_INTEL_COMMON_HYPERTHREADING) += hyperthreading.c
why do we add this line?
Removed.
https://review.coreboot.org/c/coreboot/+/43904/5/src/cpu/intel/common/voltag... File src/cpu/intel/common/voltage.c:
https://review.coreboot.org/c/coreboot/+/43904/5/src/cpu/intel/common/voltag... PS5, Line 9: #if CONFIG(GENERATE_SMBIOS_TABLES)
There is no need to guard it. If we build without SMBIOS tables, it will simply […]
Done.
https://review.coreboot.org/c/coreboot/+/43904/5/src/cpu/intel/model_2065x/K... File src/cpu/intel/model_2065x/Kconfig:
https://review.coreboot.org/c/coreboot/+/43904/5/src/cpu/intel/model_2065x/K... PS5, Line 4: if CPU_INTEL_MODEL_2065X
Was this confirmed? In the SDM it's only documented since Sandy Bridge.
Actually, I'm not sure about that. I removed CPU_INTEL_COMMON_VOLTAGE here, and it can be selected if needed.