Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85362?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/mt8196: Add booker driver ......................................................................
Patch Set 12:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85362/comment/6ec96010_51a68423?usp... : PS12, Line 8: Can you please start by describing MediaTek Booker device? Is it newly introduced with MT8196? What is it needed for? Is a blob required to run it?
PS: I couldn’t find any information on the WWW.
https://review.coreboot.org/c/coreboot/+/85362/comment/fa405e42_83ed0a58?usp... : PS12, Line 20: [booker_init] AP hash rule: 0xbe00. What is this hash rule?
File src/soc/mediatek/mt8196/include/soc/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/85362/comment/6b73f490_a9bcdd4c?usp... : PS12, Line 49: BOOTBLOCK(0x02001000, 78K) Plesae mention this increase in the commit message.