[coreboot-gerrit] Change in coreboot[master]: mb/{adlrvp, brya, sm}: Set `pch_thermal_trip` for Dynamic Thermal Shu...

[Subrata Banik (Code Review)]

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59270 )

Change subject: mb/{adlrvp, brya, sm}: Set `pch_thermal_trip` for Dynamic Thermal Shutdown
......................................................................

Patch Set 4:

(1 comment)

File src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/59270/comment/71923501_bc37db0f 
PS4, Line 95: .pch_thermal_trip = 100,
> Isn't there usually a recommended value per-chipset?

Yes, you are right. this should be optimal value based on thermal team.
> Just wondering if `chipset.cb` for alderlake makes more sense here for setting the value to 100?

Yes, i believe that makes more sense. The reason I have moved to all mainboard to allow any override if required but don't think that might even required. Will move default 100 degree to chipset.cb