Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31486 )
Change subject: soc/amd/common: Refactor AmdCreateStruct() use ......................................................................
Patch Set 6:
(1 comment)
Sorry I did not had time yesterday to continue reviewing your other patches. I do have about 2 hours now, so I'll start it now.
https://review.coreboot.org/#/c/31486/5/src/soc/amd/common/block/pi/agesawra... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/31486/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 111: return module_dispatch(AMD_RELEASE_STRUCT, &aip->StdHeader);
I don't see how AGESA.c line 58 is related to any AGESA_BOUNDS_CHK. […]
Yes, I'm aware of Marshall's (and Marc's) finding about 4 core. Also, when I started working, stoney AGESA was private due to several modifications required by Google. I am/was not aware that it has gone public, thus I don't talk about it's internals in coreboot (though I do have access to the source).