Attention is currently required from: Patrick Georgi, Arthur Heymans, Werner Zeh.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69686 )
Change subject: util/cbmem: Provide a way to override coreboot path
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Maybe also look inside the tool directory for a commonlib directory so that it could just be packa […]
That's what I was thinking, yes. I don't know if it's actually needed, but it seems like it would be better to point to the commonlib directory instead of the root of the coreboot tree, if that's what it actually needs. It doesn't need to be done here, or even at all - it's mostly something to think about for the tools that use commonlib.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69686
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2732f75310e10716e5aa74e094e0bf628ad22f0b
Gerrit-Change-Number: 69686
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Sat, 26 Nov 2022 23:43:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment