Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43776 )
Change subject: device: Add find_dev_nested_path helper function ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/43776/2/src/device/device_const.c File src/device/device_const.c:
https://review.coreboot.org/c/coreboot/+/43776/2/src/device/device_const.c@2... PS2, Line 211: unsigned int
size_t?
Done
https://review.coreboot.org/c/coreboot/+/43776/2/src/device/device_const.c@2... PS2, Line 215: if (!parent || !nested_path_length)
Check for nested_path as well?
Done
https://review.coreboot.org/c/coreboot/+/43776/2/src/device/device_const.c@2... PS2, Line 221: (
space before (
Where's build bot when you need them?
https://review.coreboot.org/c/coreboot/+/43776/2/src/device/device_const.c@2... PS2, Line 224: +
space around +
Done
https://review.coreboot.org/c/coreboot/+/43776/2/src/device/device_const.c@2... PS2, Line 224: -
space around -
Done