[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: adapt FSP GOP param to match the other FSP2.0 plat...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36353 )

Change subject: soc/intel/icelake: adapt FSP GOP param to match the other FSP2.0 platforms
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36353/2/src/soc/intel/icelake/fsp_p... 
File src/soc/intel/icelake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/36353/2/src/soc/intel/icelake/fsp_p... 
PS2, Line 98: CONFIG(RUN_FSP_GOP)
> Done

yes i did but commit msg is not conveying the problem statement

soc/intel/icelake: adapt FSP GOP param to match the other FSP2.0 platforms

Set the FSP parameter PeiGraphicsPeimInit according to RUN_FSP_GOP to
enable or skip GOP.

but unable to understand why we are setting below UPD to 0, do we see any issue ? default is anyway zero for those UPDs and you would like to double confirm the same ?

params->GtFreqMax = 0;
    	params->CdClock = 0;