[coreboot-gerrit] Change in coreboot[master]: mb/ocp/deltalake: Override uart base address via VPD variable

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45408 )

Change subject: mb/ocp/deltalake: Override uart base address via VPD variable
......................................................................

Patch Set 3:

(1 comment)

I don't think you want to override the uart_init function here. You just want to change the CONFIG from 3f8 to a different port defined by VPD. That should be generic and not platform specific code.

https://review.coreboot.org/c/coreboot/+/45408/3/src/mainboard/ocp/deltalake... 
File src/mainboard/ocp/deltalake/vpd.h:

https://review.coreboot.org/c/coreboot/+/45408/3/src/mainboard/ocp/deltalake... 
PS3, Line 37: #define UART_IOPORT_DEFAULT "0x2f8"
Why would this be a string and need to be converted?