Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34515 )
Change subject: soc/mediatek/mt8173: Refactor display driver to share common parts
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34515/7/src/soc/mediatek/common/inc...
File src/soc/mediatek/common/include/soc/ddp_common.h:
https://review.coreboot.org/c/coreboot/+/34515/7/src/soc/mediatek/common/inc...
PS7, Line 111: 2
actually we only used rdma0.
I'm keeping addressmap unchanged, since that's the map definition, which may include areas we don't really use.
Instead I'm removing the variable here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34515
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5709ab6e263caa21fdf7e799dc2ee884ffaf800
Gerrit-Change-Number: 34515
Gerrit-PatchSet: 9
Gerrit-Owner: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-CC: Yongqiang Niu
yongqiang.niu@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 05 Aug 2019 04:53:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment