Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40141 )
Change subject: Kill the dead_code macro
......................................................................
Patch Set 5:
But I would still prefer we talk about it and try to find other solutions
if you have a better idea to make the macro not cause issues like that, i'm all ears. but if it's not guaranteed to be safe and not cause issues like this again, i'd like to see it removed.
rather than cutting a feature due to a one-time bug.
The bug happened once by now, but a non-functional change that basically only slightly shifts line numbers should never ever result in a build failure. this is why i'd say that the macro is buggy
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06f825e045d3305dd8ab81311fd2d003d03ae43a
Gerrit-Change-Number: 40141
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 Apr 2020 20:26:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment