Attention is currently required from: Jayvik Desai, Pranava Y N.
Subrata Banik has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85920?usp=email )
Change subject: mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85920/comment/36524821_27c9b4e7?usp... : PS2, Line 9: since Isn't "since" the first word in this sentence? should be `Since` ?
ideally we don't use statements starting with since. ```This patch selects the ISH main firmware Kconfig to prevent google/fatcat from trying to retrieve a dummy ISH SHIM firmware version, since ISH FW in google/fatcat will be part of the kernel firmware image.```
https://review.coreboot.org/c/coreboot/+/85920/comment/f468d096_61427bf9?usp... : PS2, Line 12: none please use ISH enablement bug id ?
https://review.coreboot.org/c/coreboot/+/85920/comment/b10caa35_4c165492?usp... : PS2, Line 13: fatcat google/fatcat
https://review.coreboot.org/c/coreboot/+/85920/comment/9057422c_c75ca7f3?usp... : PS2, Line 13: =b Build ?