Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37148 )
Change subject: mb/lenovo/x60: Add vboot support ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37148/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37148/4//COMMIT_MSG@9 PS4, Line 9: This also adds vboot support for the i945 platform in general.
But adding vboot support to i945 is just adding four lines! (╯°□°)╯︵ ┻━┻ […]
Done
https://review.coreboot.org/c/coreboot/+/37148/2/src/mainboard/lenovo/x60/vb... File src/mainboard/lenovo/x60/vboot-rwa.fmd:
https://review.coreboot.org/c/coreboot/+/37148/2/src/mainboard/lenovo/x60/vb... PS2, Line 1: FLASH@0xffe00000 0x200000
I don't think it matters much on x86, other fmaps do it that way and it works
"`base`: 64 bit integer for the address of the firmware binary."
No idea if that is mapped or if that is the flash base... A lot of X86 seem to use the memory mapped address.