Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32725 )
Change subject: Replace ENV_RAMSTAGE with ENV_PAYLOAD_LOADER ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/#/c/32725/2/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/#/c/32725/2/src/include/rules.h@265 PS2, Line 265: post-CAR always build with simple device model
This should be updated to reflect the change being done.
Done
https://review.coreboot.org/#/c/32725/2/src/include/rules.h@267 PS2, Line 267: Currently there's : * no known requirement that devicetree would be needed during that stage.
This is not accurate anymore.
Done
https://review.coreboot.org/#/c/32725/2/src/lib/bootmode.c File src/lib/bootmode.c:
https://review.coreboot.org/#/c/32725/2/src/lib/bootmode.c@20 PS2, Line 20: #if ENV_PAYLOAD_LOADER
Same here. […]
Done
https://review.coreboot.org/#/c/32725/2/src/lib/timestamp.c File src/lib/timestamp.c:
https://review.coreboot.org/#/c/32725/2/src/lib/timestamp.c@50 PS2, Line 50: ramstage
Need to update the comment.
Done
https://review.coreboot.org/#/c/32725/2/src/lib/timestamp.c@55 PS2, Line 55: ramstage
this too.
Done
https://review.coreboot.org/#/c/32725/2/src/lib/timestamp.c@226 PS2, Line 226: ENV_RAMSTAGE
Shouldn't this be updated as well?
Done
https://review.coreboot.org/#/c/32725/2/src/lib/timestamp.c@305 PS2, Line 305: ramstage
Update comment too.
Done