Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32324 )
Change subject: vboot: communicate display requirements with vb2api_fw_phase1
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32324/2/src/security/vboot/vboot_logic.c
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/#/c/32324/2/src/security/vboot/vboot_logic.c@369
PS2, Line 369: DISPLAY_REQUESTED
Isn't it called DISPLAY_INIT now?
Done
https://review.coreboot.org/#/c/32324/2/src/security/vboot/vboot_logic.c@371
PS2, Line 371: DISPLAY_REQUESTED
If the context flag is called DISPLAY_INIT, I'd do the same here
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32324
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81c82c46303564b63b8a32e7f80beb9d891a4628
Gerrit-Change-Number: 32324
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Apr 2019 00:54:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment