Attention is currently required from: Matt DeVillier, Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59263 )
Change subject: Documentation/drivers: Add notes on Realtek HW EQ ......................................................................
Patch Set 4:
(8 comments)
File Documentation/drivers/realtek.md:
https://review.coreboot.org/c/coreboot/+/59263/comment/f4ec6252_37c1b9d8 PS4, Line 12: mamed
typo? ma*i*med
Done
https://review.coreboot.org/c/coreboot/+/59263/comment/63413ef2_ed6a01cb PS4, Line 4: The datasheet has extensive documentation on this, as after : it says that it supports it, it provides all the below information on : how to configure it: : : ``` : : ``` : As this information is extemely helpful, we wrote up the notes below on : how to configure it.
While I appreciate the sense of humour, I'm not sure if everyone would understand the sarcasm here. […]
Done
https://review.coreboot.org/c/coreboot/+/59263/comment/bf833514_7e0d27e3 PS4, Line 19: 53
0x53, actually. Same for all other values.
Done
https://review.coreboot.org/c/coreboot/+/59263/comment/93bb773c_d65d8f41 PS4, Line 28: 0x053404DA
nit: Hex values in coreboot are typically written in lowercase
Done
https://review.coreboot.org/c/coreboot/+/59263/comment/b50acd6a_6d29e372 PS4, Line 41: Butterworth HPF
Butterworth High-Pass Filter? Maybe link to Wikipedia? […]
Done
https://review.coreboot.org/c/coreboot/+/59263/comment/7a80982c_62ab740e PS4, Line 136:
trailing space
Done
https://review.coreboot.org/c/coreboot/+/59263/comment/6e59e3bf_641b8dd6 PS4, Line 136: /* : * EQ Mode = Boost Gain : * : * High Pass Filter 1: : * Band Width = 1000Hz : * Gain (dB) = 0dB : * : * High Pass Filter 2: : * Band Width = 1000Hz : * Gain (dB) = 0dB : * : * Band Pass Filter 1 : * Frequency = 3000Hz : * Band Width = 1000Hz : * Gain = 0dB : * : * Band Pass Filter 2 : * Frequency = 6000Hz : * Band Width = 1000Hz : * Gain = 0dB : * : * Band Pass Filter 3 : * Frequency = 9000Hz : * Band Width = 1000Hz : * Gain = 0dB : * : * Band Pass Filter 4 : * Frequency = 9000Hz : * Band Width = 1000Hz : * Gain = 0dB : * : * Low Pass Filter 1 : * Band Width = 1000Hz : * Gain (dB) = 0dB : * : * AGC Threshold = -6dB : * AGC Front Boost Gain = 6dB : * AGC Post Boost Gain = 6dB : * : * Power Output = 2.5W : */
I'd appreciate if you could split this comment and interleave the parts with the verb list, so that […]
Done
https://review.coreboot.org/c/coreboot/+/59263/comment/2277bdc1_4f038fb3 PS4, Line 306:
Missing closing ``` ?
Done