Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33198 )
Change subject: Makefile.inc: Add a class 'all' to link files in all stage except SMM
......................................................................
Patch Set 9: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/33198/9/Makefile
File Makefile:
PS9:
Should we mirror this change to libpayload/Makefile?
https://review.coreboot.org/c/coreboot/+/33198/9/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33198/9/Makefile.inc@112
PS9, Line 112: $$
Do we need the deferred substitution of $(2)? I would guess that it
boils down to evaluate it before / after the $(for ) substitution. And
shouldn't make a difference.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I955dd2dc22cb3cfc4fdf1198cfd32f56475f97c9
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Oct 2019 08:31:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
