Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28935 )
Change subject: nb/i945: Check if IGD is enabled before R/W to dev(0, 2) ......................................................................
Patch Set 1:
I don't see a way IGD could be disabled at this stage. But what about SKUs that don't have it at all? are there any (on supported boards)?
1 - In case we use an external GPU, the IGD is disabled at arly_init.c (line #686). (BTW: line +949 should be commented) 2 - there some desktop's version that do not have IGD at all. 3 - at function "sdram_power_management", we set integrated_graphics = 1 and use it for test in raminit.c line #2305 .... this do not make sense.