Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31194 )
Change subject: intel/apollolake: Add parameter to enable VTD in devicetree
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31194/1/src/soc/intel/apollolake/chip.h
File src/soc/intel/apollolake/chip.h:
https://review.coreboot.org/#/c/31194/1/src/soc/intel/apollolake/chip.h@196
PS1, Line 196: uint8_t enable_vtd;
Where have you seen it in the tree? The only thing I can find like "vtd_disable" is this one bit in […]
A Freudian slip, maybe. They call it `VtdDisable`. And I've
looked at it more closely now, it seems it's not newer plat-
forms but all the big-core ones.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0bfcf1719e1ccc678a932bf3d38c6dbce3556bc
Gerrit-Change-Number: 31194
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Feb 2019 08:53:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment