Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36794 )
Change subject: mb/intel/coffeelake_rvp: Switch to overridetree setup
......................................................................
Patch Set 6:
Patch Set 6: Code-Review+2
(2 comments)
Patch Set 5:
Anything needs to do with this patch?
I think it's good enough. Do note that all comments on a change need to be resolved to be able to merge it.
If possible, it would be good to confirm that the boards still boot fine with this change. Better safe than sorry :D
Thanks for reminding. I don't have other boards, it's a big armada. But based on the comparison with original devicetree.cb, the difference is alignment with root port on/off passing to FSP UPD.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36794
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I067bdb3fcf1218b93e52801f6db093e24d7d2b62
Gerrit-Change-Number: 36794
Gerrit-PatchSet: 6
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Dec 2019 20:31:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment