Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32533 )
Change subject: sb/{ICH7,NM10,PCH}: Use common watchdog_off function ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/#/c/32533/9/src/southbridge/intel/common/Kconfig File src/southbridge/intel/common/Kconfig:
https://review.coreboot.org/#/c/32533/9/src/southbridge/intel/common/Kconfig... PS9, Line 69: def_bool n
Just `bool` should suffice.
Done
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/Makefi... File src/southbridge/intel/common/Makefile.inc:
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/Makefi... PS12, Line 55: ramstage-$(CONFIG_SOUTHBRIDGE_INTEL_COMMON_WATCHDOG) += watchdog.c It's placed inside `ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_COMMON),y)` (and so is the used `pmbase.c`) so it does depend on it...
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/tco.h File src/southbridge/intel/common/tco.h:
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/tco.h@... PS12, Line 25: #define TCO_TMR_HLT (1 << 11) indent?