Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45571 )
Change subject: soc/intel/alderlake: Add GPIOs for Alder Lake SOC ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/acp... File src/soc/intel/alderlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/acp... PS1, Line 11: CROS_GPIO_NAME
This name is as per GPIO chapter and linux should use the same name. […]
I just wanted to make sure that we are matching Linux kernel expectations w.r.t. exposing a single device for the GPIO controller or have a device per community. I think JSL started out with a single device per community, but switched to single device for the controller.
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/gpi... File src/soc/intel/alderlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/gpi... PS1, Line 27: The GPIO pinctrl driver for Alder Lake on Linux expects 32 GPIOs per pad
we have the same practice in CNL and TGL, and don't expect to change in ADL too (what i learn from c […]
SG. Just wanted to make sure that you have talked to the kernel team. We had different implementations early on for TGL/JSL.
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/gpi... PS1, Line 36: This layout matches the Linux kernel pinctrl map for ADL at: : * linux/drivers/pinctrl/intel/pinctrl-alderlake.c
this is more over a placeholder as i understood,
Umm.. I think it would be good to point to an actual reference. I understand that this file might not be really present at this point. I was just curious if this file is already checked into some maintainer tree or some place you could point to.