Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41894 )
Change subject: ec/google: Add function ec_fill_dptf_helpers() ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41894/13/src/ec/google/chromeec/ec_... File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/41894/13/src/ec/google/chromeec/ec_... PS13, Line 251:
please check, we use space instead of tab.
Hmm, it appears that we are not very consistent with this, I see tabs in some files here and spaces in others (for entries in struct device_operations)... 😞 I tend to stick with tabs as that is our indentation method here in coreboot.
https://review.coreboot.org/c/coreboot/+/41894/13/src/ec/google/chromeec/ec_... File src/ec/google/chromeec/ec_dptf_helpers.c:
https://review.coreboot.org/c/coreboot/+/41894/13/src/ec/google/chromeec/ec_... PS13, Line 5: device.h
This is also included in src/ec/google/common/dptf.h header file.
Done
https://review.coreboot.org/c/coreboot/+/41894/7/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/dptf.c:
https://review.coreboot.org/c/coreboot/+/41894/7/src/vendorcode/google/chrom... PS7, Line 178: \_SB.DPTF"
note to self: this should probably be exported from acpigen_dptf.h instead and used here too.
Ack