Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46842 )
Change subject: soc/intel/jasperlake: Correct sequence for gpio pad group
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46842/2/src/soc/intel/jasperlake/gp...
File src/soc/intel/jasperlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/46842/2/src/soc/intel/jasperlake/gp...
PS2, Line 50: INTEL_GPP(GPP_H0, GPIO_RSVD_12, GPIO_RSVD_13),
I am still not sure how moving the reserved GPIOs help here. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46842
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6013914c88c50f4b8c60ca9a9285a8e1b214d11
Gerrit-Change-Number: 46842
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 28 Oct 2020 06:33:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment