[coreboot-gerrit] Change in coreboot[master]: mb/getac/p470: Null-terminate ec_id string buffer

[Jacob Garber (Code Review)]

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34374 )

Change subject: mb/getac/p470: Null-terminate ec_id string buffer
......................................................................

mb/getac/p470: Null-terminate ec_id string buffer

The EC ID of the ECDT needs to be null-terminated (see ACPI specification,
section 5.2.15), which currently isn't being done due to an off-by-one
error. strncpy() is bug-prone exactly because of issues like this, so just
skip it entirely and use memcpy() instead.

Change-Id: I0b62e1f32177c9768fa978053ab26bca93d7248d
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1402104
---
M src/mainboard/getac/p470/acpi_tables.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/34374/1

diff --git a/src/mainboard/getac/p470/acpi_tables.c b/src/mainboard/getac/p470/acpi_tables.c
index 57e2911..59c2876 100644
--- a/src/mainboard/getac/p470/acpi_tables.c
+++ b/src/mainboard/getac/p470/acpi_tables.c
@@ -70,7 +70,7 @@

ecdt->gpe_bit = 23; // SCI interrupt within GPEx_STS

-	strncpy((char *)ecdt->ec_id, ec_id, strlen(ec_id));
+	memcpy(ecdt->ec_id, ec_id, sizeof(ec_id));

header->checksum =
        acpi_checksum((void *) ecdt, ecdt_len);