Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34399 )
Change subject: mb/google/hatch: Add support for variant_devtree_update()
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34399/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/ramstage.c:
https://review.coreboot.org/c/coreboot/+/34399/1/src/mainboard/google/hatch/...
PS1, Line 33: variant_devtree_update();
nit: Doesn't make a difference w.r.t. functionality, but rest of the lines are dealing with getting and configuring gpio table. It would be good to place this before "base_table = ..." above or after "gpio_configure_pads_with_override(...)" just to logically group the operations being performed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34399
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e9ad360b6c02c83fe49387ce7bc66d56448ffb9
Gerrit-Change-Number: 34399
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jul 2019 14:31:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment