build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25046 )
Change subject: drivers/vpd: Add VPD support ......................................................................
Patch Set 11:
(6 comments)
https://review.coreboot.org/#/c/25046/11/src/drivers/vpd/lib_vpd.c File src/drivers/vpd/lib_vpd.c:
https://review.coreboot.org/#/c/25046/11/src/drivers/vpd/lib_vpd.c@79 PS11, Line 79: if (VPD_OK != decodeLen(max_len - *consumed, suspect code indent for conditional statements (16, 32)
https://review.coreboot.org/#/c/25046/11/src/drivers/vpd/lib_vpd.c@79 PS11, Line 79: if (VPD_OK != decodeLen(max_len - *consumed, Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/25046/11/src/drivers/vpd/lib_vpd.c@91 PS11, Line 91: if (VPD_OK != decodeLen(max_len - *consumed, suspect code indent for conditional statements (16, 40)
https://review.coreboot.org/#/c/25046/11/src/drivers/vpd/lib_vpd.c@91 PS11, Line 91: if (VPD_OK != decodeLen(max_len - *consumed, Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/25046/11/src/drivers/vpd/vpd.c File src/drivers/vpd/vpd.c:
https://review.coreboot.org/#/c/25046/11/src/drivers/vpd/vpd.c@194 PS11, Line 194: while (VPD_OK == decodeVpdString(vpd->ro_size, vpd->blob, Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/25046/11/src/drivers/vpd/vpd.c@200 PS11, Line 200: while (VPD_OK == decodeVpdString(vpd->rw_size, Comparisons should place the constant on the right side of the test