Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45336 )
Change subject: soc/intel/common/basecode: Add Intel common reset code ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45336/8/src/soc/intel/common/baseco... File src/soc/intel/common/basecode/reset/reset.c:
https://review.coreboot.org/c/coreboot/+/45336/8/src/soc/intel/common/baseco... PS8, Line 29: case FSP_STATUS_GLOBAL_RESET: nit: Maybe put a comment indicating where this is supposed to be defined?
/* Defined in each SoC's chip.h */