build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45408 )
Change subject: mb/ocp/deltalake: Override uart base address via VPD variable ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45408/2/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/uart.c:
https://review.coreboot.org/c/coreboot/+/45408/2/src/mainboard/ocp/deltalake... PS2, Line 12: if (hexstr[0] == '0' && hexstr[1] == 'x') suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/c/coreboot/+/45408/2/src/mainboard/ocp/deltalake... PS2, Line 19: else if (c >= 'a' && c <='f') spaces required around that '<=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/45408/2/src/mainboard/ocp/deltalake... PS2, Line 21: else if (c >= 'A' && c <='F') spaces required around that '<=' (ctx:WxV)