Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44196 )
Change subject: mrc_cache: Update mrc_cache data in romstage
......................................................................
Patch Set 29:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44196/29/src/drivers/mrc_cache/Kcon...
File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/44196/29/src/drivers/mrc_cache/Kcon...
PS29, Line 29: MRC_WRITE_NV_LATE
Does this option make sense to anyone? I find boot-state hooks already pretty […]
There is only one platform that is actually using this - Stoneyridge. And the change that added the Kconfig only says that the current boot state is too early: https://review.coreboot.org/c/coreboot/+/22937. From the comments on that and related CLs, it looks like probably the data is not really available by then. But, I don't really know if there are other issues as well.
As for other platforms - Intel, this needs to be done before the PRR lockdown happens. So, that is the reason for not moving Intel platforms to do these later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44196
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3430bda45484cb8c2b01ab9614508039dfaac9a3
Gerrit-Change-Number: 44196
Gerrit-PatchSet: 29
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 01 Oct 2020 20:12:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment