Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41895 )
Change subject: mb/google/volteer: Convert static ASL files to new DPTF implementation ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41895/14/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41895/14/src/mainboard/google/volte... PS14, Line 282: ## Active Policy
We need to add Weight parameter as well, which decides the priority between two sensors when they hi […]
Weight is written out, if it is not specified in the devicetree, then it defaults to 100. See the Active Policy patchset (the line looks like:
acpigen_write_integer(DEFAULT_IF_0(policies[i].weight, DEFAULT_WEIGHT));
IOW, if the user doesn't specify a weight (i.e., it's 0), then it will write out 100 as the default instead.
If it's required, then it can be added here:
policies.active[0] = "{.target=DPTF_CPU, .weight=90, .... }"
https://review.coreboot.org/c/coreboot/+/41895/14/src/mainboard/google/volte... PS14, Line 308: Passive Policy
same as above active policy comment, we need Weight here as well to avoid any kind of race condition […]
The weight parameter can be written out as well, it defaults to 100, same as for Active Policies, see the Passive Policy patchset (although it's called Priority there):
acpigen_write_integer(DEFAULT_IF_0(policies[i].priority, DEFAULT_PRIORITY));
Similar to above, if no priority is specified, it defaults to writing out 100, otherwise it can be added. I could add macros though for the cases when that is desired to be specified: DPTF_PASSIVE_PRIORITY(CPU, CPU, 95, 5000, 90) for example.
https://review.coreboot.org/c/coreboot/+/41895/14/src/mainboard/google/volte... PS14, Line 314: ## Critical Policy
In Critical policy, once the sensor hits the temperature threshold, DPTF initiates the graceful syst […]
Good catch, Sumeet I think I had it backwards. _CRT "Returns critical trip point in tenths of degrees where DPPM must perform a critical shutdown." _HOT defines a threshold for transition to S4. Will revise the naming.