Attention is currently required from: Alexander Couzens, Angel Pons, Felix Singer, Jan Philipp Groß, Paul Menzel.
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M900 (Skylake/LGA 1151) ......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/lenovo/m900/bootblock.c:
https://review.coreboot.org/c/coreboot/+/74187/comment/d7e445fd_3b09d203?usp... : PS4, Line 9: /* Change to NCT6687D_SP1 to use COM2 header */
Should probably be a Kconfig
Would tying it to `CONFIG_UART_FOR_CONSOLE` make sense? I had experimented with that locally the other day. Another thing I tried is adding a configurable option in the mainboard Kconfig to select either COM1 or COM2. With that latter option `CONFIG_UART_FOR_CONSOLE` also needs to be set to match what the devicetree sets otherwise coreboot locks up in ramstage when configuring the I/O base addresses for the COM ports in the SuperIO. The former option would also probably lock up the console if index 2 or 3 is selected. One issue with tying it to `CONFIG_UART_FOR_CONSOLE` is that it isn't very obvious which physical port is being used.