Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34657 )
Change subject: Documentation/soc/intel: Add documentation for MCU update ......................................................................
Patch Set 14:
(10 comments)
https://review.coreboot.org/c/coreboot/+/34657/14/Documentation/soc/intel/uc... File Documentation/soc/intel/ucode_update/microcode_update_model.md:
https://review.coreboot.org/c/coreboot/+/34657/14/Documentation/soc/intel/uc... PS14, Line 1: Microcode update mechanism for devices in field
#
Done
https://review.coreboot.org/c/coreboot/+/34657/14/Documentation/soc/intel/uc... PS14, Line 5: Processor microcode (MCU) is akin to processor firmware. Processors may
remove whitespace on all lines
Done
https://review.coreboot.org/c/coreboot/+/34657/14/Documentation/soc/intel/uc... PS14, Line 6: need updates to their microcode to operate correctly. These updates fix
whitespace
Done
https://review.coreboot.org/c/coreboot/+/34657/14/Documentation/soc/intel/uc... PS14, Line 10: ##Problem Statement
what about other microcode update mechanisms? […]
FIT based loading of MCU will make sure that the FW patches that are to be patched prior to reset are applied. Microcode update in BIOS e.g. during MP initialization, will not apply some FW patches. Hence the need to load the MCU via FIT.
Updated in the same in documentation
https://review.coreboot.org/c/coreboot/+/34657/14/Documentation/soc/intel/uc... PS14, Line 13: by vboot (chrome root of trust - CROT) before it is allowed to run on
whitespace
Done
https://review.coreboot.org/c/coreboot/+/34657/14/Documentation/soc/intel/uc... PS14, Line 17: proposal tries to address the issue
period
Done
https://review.coreboot.org/c/coreboot/+/34657/14/Documentation/soc/intel/uc... PS14, Line 19: Prior to CPU reset, the CPU HW locates the FIT table from the storage,
FIT specific. move to FIT documentation.
Putting this little FIT piece gives a complete picture of the update feature. We can add the same to FIT documentation as well.
https://review.coreboot.org/c/coreboot/+/34657/14/Documentation/soc/intel/uc... PS14, Line 57: a. bb_ro_ucode contains a FIT which has pointer to MCU
invalid identation
Done
https://review.coreboot.org/c/coreboot/+/34657/14/Documentation/soc/intel/uc... PS14, Line 64: a. Reserve a region in the FMAP which is equal to or greater
invalid identation
Done
https://review.coreboot.org/c/coreboot/+/34657/14/Documentation/soc/intel/uc... PS14, Line 73: **Flash Layout**
not shown
Fixed. Let me know if you are able to see. I opened it in Atom IDE it shows the vector graphic.