Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46661 )
Change subject: sc7180: Add Modem region in memlayout to avoid modem cleanup in Secboot reboot. ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46661/3/src/soc/qualcomm/sc7180/car... File src/soc/qualcomm/sc7180/carve_out.c:
https://review.coreboot.org/c/coreboot/+/46661/3/src/soc/qualcomm/sc7180/car... PS3, Line 16: uint32_t modem_id = read32(_modem_id); How do you expect this to work? You're literally reading the value right after you set it to zero!
This function is called twice by coreboot, so you can't set it to zero after reading either. If you want this to get explicitly zeroed on cold boot, that needs to be done by QC-SEC.