Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35735 )
Change subject: intel/skylake: Refactor IRQ assignments
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35735/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35735/2//COMMIT_MSG@10
PS2, Line 10: pci_devfn_t
I could rephrase this as... 'are always of the same PCI device'. […]
Yes, please reword. I was working on some patches to fix up some that divergence as well -- helper functions and not open coding direct access. Once we have that we should be able to target convergence.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35735
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc4795245187f8d70650242a56e6ce771ef2167a
Gerrit-Change-Number: 35735
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Oct 2019 23:47:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment