Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41894 )
Change subject: ec/google: Add function ec_fill_dptf_helpers()
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41894/13/src/ec/google/chromeec/ec_...
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/41894/13/src/ec/google/chromeec/ec_...
PS13, Line 251:
please check, we use space instead of tab.
https://review.coreboot.org/c/coreboot/+/41894/13/src/ec/google/chromeec/ec_...
File src/ec/google/chromeec/ec_dptf_helpers.c:
https://review.coreboot.org/c/coreboot/+/41894/13/src/ec/google/chromeec/ec_...
PS13, Line 5: device.h
This is also included in src/ec/google/common/dptf.h header file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41894
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib30072d1d0748b31bcab240a0fd0e2f12d34aaa4
Gerrit-Change-Number: 41894
Gerrit-PatchSet: 13
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jun 2020 12:52:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment