build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32020 )
Change subject: [WIP]x86: Introduce the blobolator ......................................................................
Patch Set 5:
(65 comments)
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... File src/arch/x86/libx86emu/blobolator.c:
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 40: x86emu_mem_t *emu_mem_new(unsigned perm) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 45: void x86emu_set_io_perm(x86emu_t *emu, unsigned start, unsigned end, unsigned perm) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 45: void x86emu_set_io_perm(x86emu_t *emu, unsigned start, unsigned end, unsigned perm) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 45: void x86emu_set_io_perm(x86emu_t *emu, unsigned start, unsigned end, unsigned perm) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 49: unsigned x86emu_read_byte(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 49: unsigned x86emu_read_byte(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 53: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 59: unsigned x86emu_read_byte_noperm(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 59: unsigned x86emu_read_byte_noperm(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 63: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 70: unsigned x86emu_read_word(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 70: unsigned x86emu_read_word(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 74: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 80: unsigned x86emu_read_dword(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 80: unsigned x86emu_read_dword(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 84: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 90: void x86emu_write_byte(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 90: void x86emu_write_byte(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 94: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 98: void x86emu_write_byte_noperm(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 98: void x86emu_write_byte_noperm(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 102: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 107: void x86emu_write_word(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 107: void x86emu_write_word(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 111: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 115: void x86emu_write_dword(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 115: void x86emu_write_dword(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 119: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 123: unsigned x86emu_clear_log(x86emu_t *emu, int flush) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 125: if(flush && emu->log.flush) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 126: if(emu->log.ptr && emu->log.ptr != emu->log.buf) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 131: if((emu->log.ptr = emu->log.buf)) *emu->log.ptr = 0; space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 131: if((emu->log.ptr = emu->log.buf)) *emu->log.ptr = 0; do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 131: if((emu->log.ptr = emu->log.buf)) *emu->log.ptr = 0; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 141: memset(x86, 0, sizeof *x86); sizeof *x86 should be sizeof(*x86)
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 226: static void vm_traceio_w(x86emu_t *emu, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 228: unsigned bits = type & 0xff; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 239: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 266: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 281: static void vm_traceio_r(x86emu_t *emu, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 283: unsigned bits = type & 0xff; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 294: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 318: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 334: unsigned vm_memio(x86emu_t *emu, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 334: unsigned vm_memio(x86emu_t *emu, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 337: unsigned bits = type & 0xff; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 342: switch(type) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 344: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 358: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 372: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 387: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 401: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 422: static bool x86emu_memio_drop(struct x86emu_s *emu_s, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 424: switch(type) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 439: static bool x86emu_memio_except(struct x86emu_s *emu_s, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 444: switch(type) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 472: static unsigned x86emu_memio_handler(struct x86emu_s *emu_s, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 472: static unsigned x86emu_memio_handler(struct x86emu_s *emu_s, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 539: static int x86emu_intr_handler(x86emu_t *emu, u8 num, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 552: vm_memio(emu, emu->x86.R_EIP + i - 16, &val, X86EMU_MEMIO_R|X86EMU_MEMIO_8); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 565: static void x86emu_flush_log(x86emu_t *emu, char *buf, unsigned size) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 576: unsigned stats_i[X86EMU_IO_PORTS]; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 577: unsigned stats_o[X86EMU_IO_PORTS]; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 582: unsigned def_mem_perm = X86EMU_PERM_X|X86EMU_PERM_W|X86EMU_PERM_R; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/5/src/arch/x86/libx86emu/blob... PS5, Line 583: unsigned def_io_perm = X86EMU_PERM_X|X86EMU_PERM_W|X86EMU_PERM_R; Prefer 'unsigned int' to bare use of 'unsigned'