Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31489 )
Change subject: [WIP] soc/amd/common: Use static allocation for params
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
y
https://review.coreboot.org/#/c/31489/5/src/soc/amd/common/block/pi/agesawra...
File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/31489/5/src/soc/amd/common/block/pi/agesawra...
PS5, Line 425:
:
:
:
:
:
:
:
Do you have a platform to test? I'm not comfortable approving it until it's tested. […]
I finally had a chance to test it, and as I suspected it would, it hanged at amd_init_early. That section of code is needed and I'll block any change that remove it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31489
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibef6ca8481f926d4e18e1aef5136e69f5834feb1
Gerrit-Change-Number: 31489
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 May 2019 18:59:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment