Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35605 )
Change subject: util/mb/google/hatch: fix style issues in shell script
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35605/1/util/mainboard/google/hatch...
File util/mainboard/google/hatch/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35605/1/util/mainboard/google/hatch...
PS1, Line 31: uppercase
Oh, yeah, Turkish "i" with a dot and without a dot, in both lower- and upper-case forms. […]
You're right, we should stay with romanized names, but: somebody with turkish locale running this script (extended to work beyond hatch) for, say, fizz will get FİZZ, not FIZZ
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35605
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63aa0aa633f36b9543e809fc42fac955da5960a3
Gerrit-Change-Number: 35605
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Andrew McRae
amcrae@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Sep 2019 20:34:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment