Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34939 )
Change subject: Add definition for ENV_ROMSTAGE_OR_BEFORE to <rules.h> ......................................................................
Patch Set 12:
(10 comments)
https://review.coreboot.org/c/coreboot/+/34939/10/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/34939/10/src/include/rules.h@269 PS10, Line 269: #define ENV_ROMSTAGE_OR_BEFORE \
My impression is we rarely need to know if we are executing from DRAM or XIP with cache-as-ram. […]
Ack
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/rules.h@269 PS5, Line 269: #define ENV_BEFORE_POSTCAR \
I think for most of us working on Arm, when we say "RAM" we mean DRAM. […]
Done
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/rules.h@273 PS5, Line 273: (ENV_BEFORE_POSTCAR || ENV_POSTCAR)
This can be defined listign PRE_RAM stages explicitly, to avoid ENV_BEFORE_POSTCAR.
Done
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/rules.h@278 PS5, Line 278: #define ENV_HAS_DATA_SECTION ENV_PROGRAM_IN_RAM
I'll try to update this, leveraging existing defines from memlayout.h.
Done
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/rules.h@279 PS5, Line 279: #define ENV_HAS_BSS_SECTION !(ENV_ROMSTAGE && CONFIG(CAR_GLOBAL_MIGRATION))
And ARCH_STAGE_HAS_BSS_SECTION here.
Done
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/rules.h@298 PS5, Line 298: #define ENV_CACHE_AS_RAM !ENV_PROGRAM_IN_RAM
Not sure, maybe not. […]
Done
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/stddef.h File src/include/stddef.h:
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/stddef.h@48 PS5, Line 48: #define MAYBE_BSS
I would do the renaming in separate commit. Either before or after this one.
Done
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/stddef.h@52 PS5, Line 52: #define ALLOC_LARGE_BUFFER MAYBE_BSS
Assuming heap is preferred for ramstage, I would go and put the logic in lzma.c file. […]
Ack
https://review.coreboot.org/c/coreboot/+/34939/10/src/include/symbols.h File src/include/symbols.h:
https://review.coreboot.org/c/coreboot/+/34939/10/src/include/symbols.h@75 PS10, Line 75: return !CONFIG(ARCH_X86) || ENV_ROMSTAGE_OR_BEFORE;
Well the current iteration of Picasso is using car.ld. […]
Ack
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/symbols.h File src/include/symbols.h:
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/symbols.h@75 PS5, Line 75: return !CONFIG(ARCH_X86) || ENV_BEFORE_POSTCAR;
Test is _BEFORE_ postcar. […]
Ack