[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: add volteer mainboard initial support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38620 )

Change subject: mb/google/volteer: add volteer mainboard initial support
......................................................................

Patch Set 16:

(4 comments)

https://review.coreboot.org/c/coreboot/+/38620/14/src/mainboard/google/volte... 
File src/mainboard/google/volteer/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/38620/14/src/mainboard/google/volte... 
PS14, Line 121: 	PAD_CFG_GPI_SCI_LOW(GPP_C6, NONE, PLTRST, EDGE_SINGLE),
This is not correct. It should be PAD_CFG_GPI_APIC

https://review.coreboot.org/c/coreboot/+/38620/14/src/mainboard/google/volte... 
PS14, Line 160: UP_20K
> Line 81 of the volteer GPIO spec sheet says it's needed. […]

Ack

https://review.coreboot.org/c/coreboot/+/38620/14/src/mainboard/google/volte... 
PS14, Line 162: UP_20K
> Line 82 of the volteer GPIO spec sheet says it's needed. […]

Ack

https://review.coreboot.org/c/coreboot/+/38620/14/src/mainboard/google/volte... 
PS14, Line 164: UP_20K
> Line 83 of the volteer GPIO spec sheet says it's needed. […]

Ack