Attention is currently required from: Cliff Huang, Intel coreboot Reviewers, Kyoung Il Kim.
Jérémy Compostella has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/86414?usp=email )
Change subject: soc/intel/common/gpio: Add macro for interrupt GPI with driver mode
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
It seems that this is only used by [[https://review.coreboot.org/c/coreboot/+/85200]]. I would recommend moving that change list (CL) right before it. The reason is that anticipating a need and landing it before full approval is risky. Sometimes, as you go through the review process, the need disappears, and something unnecessary gets added to the codebase.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86414?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibc1ed3089c24302bc7eb02318714b8ec464fad01
Gerrit-Change-Number: 86414
Gerrit-PatchSet: 3
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Comment-Date: Thu, 20 Feb 2025 04:40:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No