Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37921 )
Change subject: mainboard/google/hatch: Move gpio GPP_C* NC down into baseboard
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37921/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37921/5//COMMIT_MSG@13
PS5, Line 13:
: GPP_C20 is already defined in baseboard and so remove redeclarations
: from variants.
This is no longer true.
Done
https://review.coreboot.org/c/coreboot/+/37921/5//COMMIT_MSG@17
PS5, Line 17: GPP_C
nit: Effectively, this is GPP_C15 now.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37921
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I578245e24895d361d80ad016a4f18204e2b6e1ca
Gerrit-Change-Number: 37921
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 25 Dec 2019 02:38:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment