Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37262 ) Change subject: util: cbfstool: Check alignment at build time ...................................................................... Patch Set 11: (1 comment) Reading all the comments my proposal is: 1. Top level FLASH supports specifying alignment by '%alignment'. If not specified default to 4k. 2. All FMAP sections are default aligned to the FLASH alignment. 3. Sections may override alignment by '%alignment', where '%0' implies unaligned. 4. The section flags also support 'UNALIGNED' that implies '%0'. Does that make sense? https://review.coreboot.org/c/coreboot/+/37262/11/Documentation/lib/flashmap... File Documentation/lib/flashmap.md: https://review.coreboot.org/c/coreboot/+/37262/11/Documentation/lib/flashmap... PS11, Line 114: must be aligned to erase block (e.g., 4k).
we could factor out the erase size definitions from src/drivers/spi/$vendor.c
I like the idea but it's not easy because 1. one driver may support multiple flash chipsets with different block size, 2. boards may want to have multiple SPI drivers Instead I think we may add an "alignment" property to FMAP to override default alignment (4k). -- To view, visit https://review.coreboot.org/c/coreboot/+/37262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I26b394590c28667a4afcd521c7caa2009b5b98a9 Gerrit-Change-Number: 37262 Gerrit-PatchSet: 11 Gerrit-Owner: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Aaron Durbin <adurbin@chromium.org> Gerrit-CC: Patrick Georgi <pgeorgi@google.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 04 Dec 2019 16:09:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin <adurbin@chromium.org> Comment-In-Reply-To: Julius Werner <jwerner@chromium.org> Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com> Gerrit-MessageType: comment