Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32373 )
Change subject: rockchip: rk3399: increase memory for fit payload. ......................................................................
Patch Set 2: Code-Review+2
After making this change, flashing and cold resetting, you get this:
CBFS: 'Master Header Locator' located CBFS at [20100:800000) CBFS: Locating 'fallback/payload' CBFS: Found @ offset 1a000 size 6f6a58 Payload not loaded.
Okay, sorry, I re-read the FIT code and I realize why you need this now. I also don't see a simple way to improve it (we have to allocate the loaded FIT image somewhere, and the heap isn't going to be big enough either, so might as well use the CBFS cache I guess). We can take this patch as is.
Maybe you could add an error message to fit_payload() (the if (data == NULL) check at the top) that makes it more obvious to the user that they need to increase their CBFS cache? "Payload not loaded" alone is not very helpful.