[coreboot-gerrit] Change in coreboot[master]: soc/intel/{adl,cnl,ehl,icl,jsl,tgl}: Clear RTC_BATTERY_DEAD

[Furquan Shaikh (Code Review)]

Attention is currently required from: Tim Wawrzynczak, Angel Pons, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56617 )

Change subject: soc/intel/{adl,cnl,ehl,icl,jsl,tgl}: Clear RTC_BATTERY_DEAD
......................................................................

Patch Set 1:

(1 comment)

File src/soc/intel/alderlake/pmutil.c:

https://review.coreboot.org/c/coreboot/+/56617/comment/d93d8540_75cd3747 
PS1, Line 188: soc_get_rtc_failed
`soc_get_rtc_failed()` gets called only in ramstage. So, clearing `RTC_BATTERY_DEAD` here wouldn't really fix the boot loop you mentioned in commit message.

If you decide to move this to `vbnv_cmos_failed()` you will have to ensure that the cmos_init() flow still looks correct.