Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44353 )
Change subject: soc/amd/common/espi_util: clarify espi_open_io_window
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44353/1/src/soc/amd/common/block/lp...
File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/44353/1/src/soc/amd/common/block/lp...
PS1, Line 186: else {
sure, it's not required and doesn't change behavior, but i find this much clearer. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44353
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3039817afd79c30a2df2f2f54e7848f52dc2c487
Gerrit-Change-Number: 44353
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Sep 2020 12:26:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment