Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32963 )
Change subject: soc/intel/braswell: Use common cpu/intel/car code
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Might consider correcting some comment.
https://review.coreboot.org/#/c/32963/7/src/drivers/intel/fsp1_1/cache_as_ra...
File src/drivers/intel/fsp1_1/cache_as_ram.inc:
https://review.coreboot.org/#/c/32963/7/src/drivers/intel/fsp1_1/cache_as_ra...
PS7, Line 135: /* Create cache_as_ram_params on stack */
Change comment in something like Create BIST and TSC on stack
https://review.coreboot.org/#/c/32963/7/src/drivers/intel/fsp1_1/cache_as_ra...
PS7, Line 145: /* Call cache_as_ram_main(struct cache_as_ram_params *) */
This comment is not updated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32963
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f03e5a808f00157fdd807b104417a54e4bde7b2
Gerrit-Change-Number: 32963
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 27 May 2019 11:34:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment