Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Subrata Banik.
hualin wei has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/86510?usp=email )
Change subject: mb/google/nissa/var/pujjoniru: Modify the gpio of GPIO_PCH_WP
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/86510/comment/095278f1_efc587c7?usp... :
PS3, Line 14: #if CONFIG(BOARD_GOOGLE_PUJJONIRU)
: #define GPIO_PCH_WP GPP_E17
: #else
: #define GPIO_PCH_WP GPP_E12
: #endif
Done
We continued to try this method and found that we need to overwrite `cros_gpios` under `src/mainboard/google/brya/variants/baseboard/nissa/gpio.c` for it to take effect.
This is our plan B. https://review.coreboot.org/c/coreboot/+/86554
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86510?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iee76fa8b357aa472699f17789b2c718028f812a3
Gerrit-Change-Number: 86510
Gerrit-PatchSet: 4
Gerrit-Owner: hualin wei
weihualin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cindy Lu
luyi8@huaqin.corp-partner.google.com
Gerrit-CC: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 24 Feb 2025 06:33:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: hualin wei
weihualin@huaqin.corp-partner.google.com
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com